feat: remove all the commerce coordinator #35527
Open
+6
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiyaIshaque
force-pushed
the
attiya/SONIC-714-remove-code
branch
2 times, most recently
from
b0e2f58
to
47a1a0c
Compare
aht007
reviewed
Oct 1, 2024
| @@ -21,8 +21,7 @@ | |||
| $('button[name=verified_mode]').click(function(e){ | |||
| e.preventDefault(); | |||
| window.location.href = '${ecommerce_payment_page | n, js_escaped_string}?sku=' + | |||
| encodeURIComponent('${sku | n, js_escaped_string}') + | |||
There was a problem hiding this comment.
We need to revert this change. We need to keep appending the course_run_key identifier wherever we are
| return False | ||
|
|
||
|
|
||
| def _auto_enroll(course_enrollment): |
There was a problem hiding this comment.
Please coordinate with Noyan about this change as his current work relies on using this utility function.
attiyaIshaque
force-pushed
the
attiya/SONIC-714-remove-code
branch
from
47a1a0c
to
7c07659
Compare
attiyaIshaque
force-pushed
the
attiya/SONIC-714-remove-code
branch
from
7c07659
to
5613fd3
Compare
|
@aht007 I have addressed your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.